Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add adjust_message_entities_to_utf_16 utility #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 6, 2024
Merged

Add adjust_message_entities_to_utf_16 utility #4323

merged 6 commits into from
Jul 6, 2024

Conversation

Antares0982
Copy link
Contributor

add adjust_message_entities_to_utf_16 for #4319

@Antares0982 Antares0982 mentioned this pull request Jun 24, 2024
Closed
@Antares0982
Copy link
Contributor Author

Antares0982 commented Jun 24, 2024 •
edited
Loading

Is there anything else should be added/changed?

Bibo-Joshi
Bibo-Joshi requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you very much for the PR! I left a number of comments. The overall logic is fine - thanks for catching the necessity for sorting! - but there are some things that can be improved :)

@Antares0982
Copy link
Contributor Author

Ok, I will fix these in the next few days

@Antares0982 Antares0982 requested a review from Bibo-Joshi July 1, 2024 14:43
Bibo-Joshi
Bibo-Joshi requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Left some more comments, mostly about documentation :)
Please don't force-push additional changes, as that makes it hard to see what which parts I've already reviewed.

harshil21
harshil21 reviewed Jul 1, 2024
View reviewed changes
@Poolitzer Poolitzer linked an issue Jul 3, 2024 that may be closed by this pull request
[FEATURE] tool for translating unicode offsets to utf-16 offsets of MessageEntity #4319
Closed
Bibo-Joshi
Bibo-Joshi approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional updates! LGTM now :) If @harshil21 approves as well, we can merge.

harshil21
harshil21 requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last doc fix

@Bibo-Joshi Bibo-Joshi merged commit 42d7c8c into python-telegram-bot:master Jul 6, 2024
17 of 23 checks passed
@Bibo-Joshi
Copy link
Member

Thank you very much for the nice contribution!

@Bibo-Joshi Bibo-Joshi mentioned this pull request Jul 12, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 requested changes

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] tool for translating unicode offsets to utf-16 offsets of MessageEntity
3 participants
@Antares0982 @Bibo-Joshi @harshil21