Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Api 7.7 #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Api 7.7 #4356

merged 6 commits into from
Jul 9, 2024

Conversation

Poolitzer
Copy link
Member

No description provided.

@Poolitzer Poolitzer added the ⚙️ bot-api affected functionality: bot-api label Jul 7, 2024
@Poolitzer Poolitzer linked an issue Jul 7, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme.rst needs updating but otherwise looks good!

Comment on lines +582 to +583
about a refunded payment, information about the payment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
about a refunded payment, information about the payment.
about a refunded payment, information about the payment.
.. seealso::
`Telegram Docs on payments <https://core.telegram.org/bots/api#payments>`_

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we could definitely add this, it would also need to be added to successful_payment and paid_media.

All of them getting this big block might take up unnecessary amount of screen time, I would do an inline link then instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I was just following what hinrich started with 027263a, inline link also works with me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think that is really a lot of wasted screen space

Comment on lines +904 to +905
about a refunded payment, information about the payment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
about a refunded payment, information about the payment.
about a refunded payment, information about the payment.
.. seealso::
`Telegram Docs on payments <https://core.telegram.org/bots/api#payments>`_

Co-authored-by: Harshil <[email protected]>
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick PR! one pre-commit finding. test failures seem unrelated

@Bibo-Joshi Bibo-Joshi merged commit 71e4015 into master Jul 9, 2024
27 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api-7.7 branch July 9, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] API 7.7
3 participants