-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Docs fix/add introductory paragraphs to subsections #4389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fix/add introductory paragraphs to subsections #4389
Conversation
…file.rst instead of passport-tree.rst
Hello, thanks for the PR. Please dont modify the gitignore. The available types change is not needed, neither do we provide json objects nor does python have 32 bit signed integers. For the rest without looking deeply into it: Please use for linking to ours the internal links as we do in the docs. So e.g. paramref: |
Hi. the linking is case sensitive, i.e. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I left a few comments. In addition, what's still missing is making the "more about" links ponit to the PTB docs rather than TG docs as explained in #4380, e.g.
python-telegram-bot/telegram/_reply.py
Line 95 in 422993b
`More about games >> <https://core.telegram.org/bots/api#games>`_. |
…ram.org/bots/inline, update a line from please see ours to please see telegrams and setinline to ensure its rendored correctly.
…e PTB docs rather than TG docs
Hello, is everything done, or should I do anything else? |
…ttps://github.com/mohdyusuf2312/fix-python-telegram-bot into docs-fix/add-introductory-paragraphs-to-subsections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two small fixes that are not you're fault (see tdlib/telegram-bot-api#617).
LGTM now. Thanks very much for the PR and your patience during the review process :)
Thank you sir, I feel very happy to complete my first contribution to open source. :) |
Description
This pull request adds introductory paragraphs to several sections in the PTB documentation and updates the "More info on xy" links to point to the PTB docs where appropriate.
Changes Made
AUTHORS.rst
file.Issue Addressed
docs/fix #4380
Available Types section before
Available Types section after
Stickers section before
Stickers section after
Inline Mode section before
Inline Mode section after
Payment section before
Payment section after
Games section before
Games section after
Passport section before
Passport section after
Additional Information
Please review the changes and let me know if any further adjustments are needed.