Fixed obsolete documentation. #4448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed warnings of the thumbnail_url parameters, regarding the deprecated parameter thumb, as well as the optional annotation in the docs.
Instead, added 'versionchanged' everywhere pointing to 20.5, the version where the thumb parameter was removed.
Added a new substitutions ('thumbnail_url_mandatory') to global.rst, used in all these 'versionchanged'.
Also removed the now obsolete 'Raises' paragraphs from all classes.
For file inlinequeryresultvideo.py it was also necessary to remove the optional annotation as well as the warning from title parameter. this parameter had to be made optional earlier, to be able to made thumb_url/thumbnail_url optional.
Also had a look at the other inlinequeryresult* files, but there seems everything to be all right.
Bibo-Joshi
approved these changes
Sep 1, 2024
bab361e
into
python-telegram-bot:doc-fixes
5 of 23 checks passed
Bibo-Joshi
added a commit
that referenced
this pull request
Sep 1, 2024
Co-authored-by: Harshil <[email protected]> Co-authored-by: Palaptin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed warnings of the thumbnail_url parameters, regarding the deprecated parameter thumb, as well as the optional annotation in the docs. Instead, added 'versionchanged' everywhere pointing to 20.5, the version where the thumb parameter was removed. Added a new substitutions ('thumbnail_url_mandatory') to global.rst, used in all these 'versionchanged'. Also removed the now obsolete 'Raises' paragraphs from all classes. For file inlinequeryresultvideo.py it was also necessary to remove the optional annotation as well as the warning from title parameter. this parameter had to be made optional earlier, to be able to made thumb_url/thumbnail_url optional.
Also had a look at the other inlinequeryresult* files, but there seems everything to be all right.