Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make Tests for telegram.ext Independent of Networking #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2024
Merged

Make Tests for telegram.ext Independent of Networking #4454

merged 7 commits into from
Sep 9, 2024

Conversation

Bibo-Joshi
Copy link
Member

By cutting of the internet connection in the fixtures

  • provide a new fixture offline_bot that has no internet connection
  • override fixtures for the tests in ext to have no internet connection
  • manually adapt a few tests
  • also move other ext-only-fixtures from conftest to ext\conftest on the fly

Let's see if I got everything in local testing

supersedes #4317. Although this PR here doesn't cover cutting off the internet connection in the *WithoutRequest tests, I don't think I'll follow up on that for the reasons pointed out in #4317.

@Bibo-Joshi
Make Tests for telegram.ext Independent of Networking
778cc0c 
By cutting of the internet connection in the fixtures
@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Sep 3, 2024
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 September 3, 2024 03:24
This was referenced Sep 3, 2024
Open
Closed
harshil21
harshil21 reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me. Regarding the WithoutRequest tests, after we use offline_bot there as well, I'm wondering if we can disallow the bot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.

We can get the fixture list using fixturenames it seems.

@Bibo-Joshi
Copy link
Member Author

Alright, looks good to me. Regarding the WithoutRequest tests, after we use offline_bot there as well, I'm wondering if we can disallow the bot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.

I would like to move this to a different PR …

@Bibo-Joshi
Copy link
Member Author

All right. Looks like I've got all tests working by now and also managed to reduce repetitions a bit. So now actually ready for review 😅

@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 8, 2024
Merged
harshil21
harshil21 reviewed Sep 8, 2024
View reviewed changes
@Bibo-Joshi Bibo-Joshi merged commit 0b352b0 into master Sep 9, 2024
24 of 25 checks passed
@Bibo-Joshi Bibo-Joshi deleted the no-request-tests branch September 9, 2024 05:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bibo-Joshi @harshil21