Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@harshil21
Copy link
Member

Part of #4459

Checklist for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or .. versionremoved:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_

  • Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only
  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that accept chat/user_id
    • In :class:~telegram.Message for all methods that accept chat_id and message_id
    • For new :class:~telegram.Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables

    • Link new and existing constants in docstrings instead of hard-coded numbers and strings

    • Add new message types to :attr:telegram.Message.effective_attachment

    • Added new handlers for new update types

      • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types

    • Added or updated documentation for the changed class(es) and/or method(s)

    • Added the new method(s) to _extbot.py

    • Added or updated bot_methods.rst

    • Updated the Bot API version number in all places: README.rst (including the badge) and telegram.constants.BOT_API_VERSION_INFO

    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains :class:~telegram.Message

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Sep 8, 2024
@harshil21 harshil21 changed the base branch from master to api-7.10 September 8, 2024 04:23
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Just a few nitpicks :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 8, 2024
@harshil21
Copy link
Member Author

harshil21 commented Sep 8, 2024

Should I adjust the type completness passing threshold value? It seems all the handler files have some type problems so that's why the check failed

nvm: I think we used to have a threshold, now it doesn't seem to exist

@Bibo-Joshi
Copy link
Member

Without having looked too closely, my guess is that there is only one typing problem. the rest propagates through the other classes b/c of the "Generic" dependencies they have on each other

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi
Copy link
Member

lgtm, then, merge at will :)

@harshil21 harshil21 merged commit 37783fa into api-7.10 Sep 11, 2024
@harshil21 harshil21 deleted the api-7.10-update-arg branch September 11, 2024 20:38
Bibo-Joshi added a commit that referenced this pull request Sep 17, 2024
Co-authored-by: aelkheir <[email protected]>
Co-authored-by: Bibo-Joshi <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants