-
Notifications
You must be signed in to change notification settings - Fork 5.9k
API 7.10 - PaidMediaPurchased
#4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! Just a few nitpicks :)
|
Should I adjust the type completness passing threshold value? It seems all the handler files have some type problems so that's why the check failed nvm: I think we used to have a threshold, now it doesn't seem to exist |
|
Without having looked too closely, my guess is that there is only one typing problem. the rest propagates through the other classes b/c of the "Generic" dependencies they have on each other |
|
apparently the initial decrease from 1.0 to 0.976 was caused by a pyright udpdate. compare the runs for https://github.com/python-telegram-bot/python-telegram-bot/actions/runs/10030792499/job/27720490377 |
|
lgtm, then, merge at will :) |
Co-authored-by: aelkheir <[email protected]> Co-authored-by: Bibo-Joshi <[email protected]>

Part of #4459
Checklist for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor.. versionremoved:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__AUTHORS.rst(optional)__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorIf the PR contains API changes (otherwise, you can ignore this passage)
Checked the Bot API specific sections of the
Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_Created a PR to remove functionality deprecated in the previous Bot API release (
see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)New classes:
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-onlyAdded new shortcuts:
~telegram.Chat& :class:~telegram.Userfor all methods that acceptchat/user_id~telegram.Messagefor all methods that acceptchat_idandmessage_id~telegram.Messageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id~telegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
Added new constants at :mod:
telegram.constantsand shortcuts to them as class variablesLink new and existing constants in docstrings instead of hard-coded numbers and strings
Add new message types to :attr:
telegram.Message.effective_attachmentAdded new handlers for new update types
~telegram.ext.ConversationHandlerAdded new filters for new message (sub)types
Added or updated documentation for the changed class(es) and/or method(s)
Added the new method(s) to
_extbot.pyAdded or updated
bot_methods.rstUpdated the Bot API version number in all places:
README.rst(including the badge) andtelegram.constants.BOT_API_VERSION_INFOAdded logic for arbitrary callback data in :class:
telegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/contains :class:~telegram.Message