-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Bump APS & Deprecate pytz Support
#4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump APS & Deprecate pytz Support
#4582
Conversation
This makes the tests fail. Will need evaluation.
This is interesting in terms of persistency. Nothing I would see us following up on anytime soon, but at least once APS 4.x is stable, it might be worth anyother look |
a6a779b to
17f95e3
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
17f95e3 to
ea6f067
Compare
Updates the requirements on [apscheduler](https://github.com/agronholm/apscheduler) to permit the latest version. - [Release notes](https://github.com/agronholm/apscheduler/releases) - [Changelog](https://github.com/agronholm/apscheduler/blob/3.11.0/docs/versionhistory.rst) - [Commits](agronholm/apscheduler@3.10.4...3.11.0) --- updated-dependencies: - dependency-name: apscheduler dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
ea6f067 to
8c02b05
Compare
Updates the requirements on [apscheduler](https://github.com/agronholm/apscheduler) to permit the latest version. - [Release notes](https://github.com/agronholm/apscheduler/releases) - [Changelog](https://github.com/agronholm/apscheduler/blob/3.11.0/docs/versionhistory.rst) - [Commits](agronholm/apscheduler@3.10.4...3.11.0) --- updated-dependencies: - dependency-name: apscheduler dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
8c02b05 to
fcccd32
Compare
…lt-3.12.0 # Conflicts: # telegram/ext/_jobqueue.py # tests/auxil/bot_method_checks.py # tests/conftest.py
….10.4-and-lt-3.12.0' into dependabot/pip/apscheduler-gte-3.10.4-and-lt-3.12.0 # Conflicts: # pyproject.toml
|
Turns out that with apscheduler deprecating pytz support, we can now do that as well and use the
after a merge, the wiki page on defaults should be updated |
pytz Support
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nitpicks and questions
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the requirements on apscheduler to permit the latest version.
Release notes
Sourced from apscheduler's releases.
Changelog
Sourced from apscheduler's changelog.
... (truncated)
Commits
6c72a51Backported release job from master4b96510Added the release versionfcec69cAdded user's guide section for export/import50f67c8Added scheduler methods for job export/import40431e5Removed the obsoletetimedelta_secondsfunction9483bb4Rearranged triggers tests to better match the master branchac55c86Fixed project links to point to the correct branch on RTD811e973Changed version history formatting to match the master branchf3c68dfPass pool_kwargs to the replacement process pool too4584091Removed unwarranted classifierYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)