-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Full Support for Bot API 8.2 #4633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… this without docs grrr...
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks quite good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the nice & quick PR. I left only a few nitpicks :)
Co-authored-by: Harshil <[email protected]> Co-authored-by: Bibo-Joshi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo^2
Thanks again for the fast PR! I'll get the release started |
I am surprised no test failed when I deprecated the hide_url argument, but I am too tired rn to decide if that is good/bad or if I already fixed it.