Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor Tests for TelegramObject Classes with Subclasses #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 6, 2025

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jan 19, 2025

closes #4652

@Bibo-Joshi Bibo-Joshi added the 🛠 refactor change type: refactor label Jan 19, 2025
@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Jan 19, 2025
@Bibo-Joshi Bibo-Joshi changed the title Refactor Tests for MenuButton Refactor Tests for TelegramObject Classes with Subclasses Jan 19, 2025
@Bibo-Joshi Bibo-Joshi marked this pull request as draft January 19, 2025 16:19
Copy link

codecov bot commented Jan 19, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
6502 3 6499 675
View the top 3 failed tests by shortest run time
tests._files.test_animation.TestAnimationWithoutRequest::test_expected_values
Stack Traces | 0.002s run time
self = <tests._files.test_animation.TestAnimationWithoutRequest object at 0x107399c40>
animation = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATXnTGeNRiqItC7_4j2V1BlU1eZtD7qjAALAGgACrWppUJqwnZXw6InBAQAHcw...LAGgACrWppUJqwnZXw6InBAQAHcwADNgQ', file_size=2744, file_unique_id='AQADwBoAAq1qaVB4', height=50, width=50), width=640)

    def test_expected_values(self, animation):
>       assert animation.mime_type == self.mime_type
E       AssertionError: assert 'image/gif' == 'video/mp4'
E         
E         - video/mp4
E         + image/gif

tests/_files/test_animation.py:69: AssertionError
tests._files.test_animation.TestAnimationWithRequest::test_send_animation_url_file
Stack Traces | 0.221s run time
self = <tests._files.test_animation.TestAnimationWithRequest object at 0x107399b80>
bot = PytestExtBot[token=629326538:AAFRrZJrB7oB3muzGsGJXUvGE5CQzM5CU4o]
chat_id = '675666224'
animation = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATXnTGeNRiqItC7_4j2V1BlU1eZtD7qjAALAGgACrWppUJqwnZXw6InBAQAHcw...LAGgACrWppUJqwnZXw6InBAQAHcwADNgQ', file_size=2744, file_unique_id='AQADwBoAAq1qaVB4', height=50, width=50), width=640)

    async def test_send_animation_url_file(self, bot, chat_id, animation):
        message = await bot.send_animation(
            chat_id=chat_id, animation=self.animation_file_url, caption=self.caption
        )
    
        assert message.caption == self.caption
    
        assert isinstance(message.animation, Animation)
        assert isinstance(message.animation.file_id, str)
        assert isinstance(message.animation.file_unique_id, str)
        assert message.animation.file_id
        assert message.animation.file_unique_id
    
>       assert message.animation.duration == animation.duration
E       AssertionError: assert 1 == 0
E        +  where 1 = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, duration=1, file_id='CgACAgQAAxkDAAE1TNpnc0T0TcZdR4Sqb_r1u5XOTn1iJgACNwEAAqrMPVMUveVgZ_74JjYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', height=180, mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320), width=320).duration
E        +    where Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, duration=1, file_id='CgACAgQAAxkDAAE1TNpnc0T0TcZdR4Sqb_r1u5XOTn1iJgACNwEAAqrMPVMUveVgZ_74JjYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', height=180, mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320), width=320) = Message(animation=Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, duration=1, file_id='CgACAgQAAxkDAAE1TNpnc0T0TcZdR4Sqb_r1u5XOTn1iJgACNwEAAqrMPVMUveVgZ_74JjYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', height=180, mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320), width=320), caption='Test *animation*', channel_chat_created=False, chat=Chat(first_name='PTB', id=675666224, last_name='Test user', type=<ChatType.PRIVATE>), date=datetime.datetime(2025, 1, 19, 18, 36, 39, tzinfo=datetime.timezone.utc), delete_chat_photo=False, document=Document(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, file_id='CgACAgQAAxkDAAE1TNpnc0T0TcZdR4Sqb_r1u5XOTn1iJgACNwEAAqrMPVMUveVgZ_74JjYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATVM2mdzRPRNxl1HhKpv-vW7lc5OfWImAAI3AQACqsw9UxS95WBn_vgmAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320)), from_user=User(first_name='PTB tests on Travis using CPython 3.5', id=629326538, is_bot=True, username='ptb_travis_cpython_35_bot'), group_chat_created=False, message_id=3532629, supergroup_chat_created=False).animation
E        +  and   0 = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATXnTGeNRiqItC7_4j2V1BlU1eZtD7qjAALAGgACrWppUJqwnZXw6InBAQAHcwADNgQ', 'file_unique_id': 'AQADwBoAAq1qaVB4', 'file_size': 2744, 'width': 50, 'height': 50}}, duration=0, file_id='CgACAgQAAxkDAAE150xnjUYqiLQu_-I9ldQZVNXmbQ-6owACwBoAAq1qaVCasJ2V8OiJwTYE', file_name='game.gif', file_size=36535, file_unique_id='AgADwBoAAq1qaVA', height=360, mime_type='image/gif', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATXnTGeNRiqItC7_4j2V1BlU1eZtD7qjAALAGgACrWppUJqwnZXw6InBAQAHcwADNgQ', file_size=2744, file_unique_id='AQADwBoAAq1qaVB4', height=50, width=50), width=640).duration

tests/_files/test_animation.py:271: AssertionError
tests._files.test_animation.TestAnimationWithRequest::test_send_all_args
Stack Traces | 0.621s run time
self = <tests._files.test_animation.TestAnimationWithRequest object at 0x1073b69d0>
bot = PytestExtBot[token=629326538:AAFRrZJrB7oB3muzGsGJXUvGE5CQzM5CU4o]
chat_id = '675666224'
animation_file = <_io.BufferedReader name='.../tests/data/game.gif'>
animation = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATXnTGeNRiqItC7_4j2V1BlU1eZtD7qjAALAGgACrWppUJqwnZXw6InBAQAHcw...LAGgACrWppUJqwnZXw6InBAQAHcwADNgQ', file_size=2744, file_unique_id='AQADwBoAAq1qaVB4', height=50, width=50), width=640)
thumb_file = <_io.BufferedReader name='.../tests/data/thumb.jpg'>

    async def test_send_all_args(self, bot, chat_id, animation_file, animation, thumb_file):
        message = await bot.send_animation(
            chat_id,
            animation_file,
            duration=self.duration,
            width=self.width,
            height=self.height,
            caption=self.caption,
            parse_mode="Markdown",
            disable_notification=False,
            protect_content=True,
            thumbnail=thumb_file,
            has_spoiler=True,
            show_caption_above_media=True,
        )
    
        assert isinstance(message.animation, Animation)
        assert isinstance(message.animation.file_id, str)
        assert isinstance(message.animation.file_unique_id, str)
        assert message.animation.file_id
        assert message.animation.file_unique_id
>       assert message.animation.file_name == animation.file_name
E       AssertionError: assert 'game.gif.mp4' == 'game.gif'
E         
E         - game.gif
E         + game.gif.mp4
E         ?         ++++

tests/_files/test_animation.py:237: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review January 19, 2025 18:22
@Bibo-Joshi Bibo-Joshi merged commit f9f1533 into master Feb 6, 2025
24 checks passed
@Bibo-Joshi Bibo-Joshi deleted the chore/#4652-menubutton branch February 6, 2025 11:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 refactor change type: refactor ⚙️ tests affected functionality: tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Tests for Classes with Subclass-de_json
1 participant