Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Api 9.0 business methods #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025
Merged

Api 9.0 business methods #4757

merged 8 commits into from
Apr 16, 2025

Conversation

Bibo-Joshi
Copy link
Member

  • references to BusinessBotRights can be added once implemented. the attributes are mentioned in the docs of the bot methods
  • naming of Message.read_business_message can be discussed. Just Message.read doesn't sufficiently highlight the business connection IMO but Message.read_business_message is the complete name again … not really happy with it.

@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Apr 14, 2025
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 14, 2025
35 tasks
Copy link
Member

@aelkheir aelkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Changes look good 😄 , just left some minor comments.

user = User(1, "first", False)
user_chat_id = 1
date = dtm.datetime.utcnow()
can_reply = True
Copy link
Member

@aelkheir aelkheir Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a reminder this will also need to be adjusted if/when

gets merged first.

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the set_business_account_profile_photo and remove_business_account_profile_photo methods are missing, not sure if that was intentional or not...

I'm fine with the naming of message.read_business_message. Rest of the changes look good to me!

@Bibo-Joshi
Copy link
Member Author

the set_business_account_profile_photo and remove_business_account_profile_photo methods are missing, not sure if that was intentional or not...

Yup, those require new classes which I didn't have time to implement yet :)

I'm fine with the naming of message.read_business_message. Rest of the changes look good to me!

🥳

@Bibo-Joshi Bibo-Joshi merged commit 2144c78 into api_9.0 Apr 16, 2025
38 of 40 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api_9.0-business-methods branch April 16, 2025 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants