fix: make gender input case-insensitive and clean up pre-commit config #4855
Conversation
| @@ -145,7 +145,7 @@ def main() -> None: | |||
| conv_handler = ConversationHandler( | |||
| entry_points=[CommandHandler("start", start)], | |||
| states={ | |||
| GENDER: [MessageHandler(filters.Regex("^(Boy|Girl|Other)$"), gender)], | |||
| GENDER: [MessageHandler(filters.Regex("(?i)^(Boy|Girl|Other)$"), gender)], | |||
There was a problem hiding this comment.
Add a comment saying that this is a case-insensitive
|
can not pass CI. output looks like
|
|
I'm not sure what could be causing that. Maybe run: |
There was a problem hiding this comment.
Kindly also add a new file changes/unreleased/4855.8hCFRFMeMaRWpBEYaxrTMq.toml with the following content:
other= "Make Gender Input Case-Insensitive in ``conversationbot.py``"
[[pull_requests]]
uid = "4855"
author_uid = "fengxiaohu"
closes_threads = ["4846"]
.pre-commit-config.yaml
Outdated
| @@ -80,4 +80,4 @@ repos: | |||
| name: isort | |||
| args: | |||
| - --diff | |||
| - --check | |||
| - --check | |||
There was a problem hiding this comment.
please add an empty newline at the end of the file to completely revert your changes
Summary
This PR improves the gender input handling in
examples/conversationbot.pyby using a case-insensitive regex.It also corrects a pre-commit hook configuration issue in
.pre-commit-config.yaml(invalidstagesfield inisort).Changes
(?i)regex..pre-commit-config.yamlto fixisorthook crash due to invalid stages.ruff,black,flake8,isort, andmypy.Check-list
pre-commit run -a).. versionchanged:: NEXT.VERSIONto example function (optional)AUTHORS.rst(optional)