Remove deprecated code #408 part 1 #564
Conversation
|
@rahiel is there a way to run the tests on Windows? Having to rely on Travis to test it so I can find usage of deprecated methods. |
|
If you did the setup from the contribution guide, you can run the tests with |
|
@rahiel thanks. I only saw the "make tests" command being mentioned; should I open a new issue/PR to include it in the contribution guide? |
|
I'll add a note to guide, you can focus on this PR :) |
|
@rahiel ready for review :) |
telegram/ext/dispatcher.py
Outdated
| # async threads must be join()ed only after the dispatcher thread was joined, | ||
| # otherwise we can still have new async threads dispatched | ||
| # async threads must be join()ed only after the dispatcher thread was joined, | ||
| # otherwise we can still have new async threads dispatched |
There was a problem hiding this comment.
Why did you misalign the comments here? Same at line 280
There was a problem hiding this comment.
Oh, that must have been the pre-commit hooks. I don't remember making the change.
There was a problem hiding this comment.
That's weird, but our pre-commit hooks have given us lots of trouble already...
Could you fix the alignment and skip the pre-commit hooks by doing git commit --no-verify?
Everything else looks good, will be ready to merge after this.
|
@rahiel fixed. |
|
Thanks for you contribution @Neurrone! Your PR is now ready to be merged. |
|
Excellent :) Thank you for your contribution! |
Part 1 for fixing #408