docs: set minimum Sphinx version to version running at read the docs #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You realize there was a reason to have 1.5.4 as the min version right? Did I look at the changelogs wrong or something? (also the comment definitely needs to go if that's no longer the reason to have the min version... in fact just remove the statement completely (by commenting)...) |
|
What's with this? Currently I'm building docs with sphinx 1.6.1 without any trouble. |
|
@bomjacob yeah I wasn't thinking clearly here, closing this PR. @Eldinnie it's about the documentation builds failing at read the docs. |
|
@bomjacob Hmm not that I know |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #684, the doc builds are failing because of the version requirement.