Use consistent hash length #410
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156 by always using
--abbrev=7ingit describecalls to ensure hashes are consistent.I went with 7 characters, because that's also the length used when using
git rev-parse --short HEADwhendescribeis not available.This will make sure that the version strings generated by
versioneerare consistent across different machines and environments.(I recently ran into an issue with a development version of
daskwhere the short hash varied between environments)