Add support for Python 3.8 #675

aaugustin · 2019-10-05T11:57:28Z

This is the official recommendation of Python core devs. The code is taken from the current 3.7 branch.

It adds only one method for flow control. Copy it, as we've already copied the rest of the flow control implementation.

It's a better name for a function that writes bytes.

codecov · 2019-10-05T12:04:57Z

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #675   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     30    +2     
  Lines        4382   4424   +42     
  Branches      407    408    +1     
=====================================
+ Hits         4382   4424   +42

Impacted Files	Coverage Δ
src/websockets/server.py	`100% <100%> (ø)`	⬆️
src/websockets/handshake.py	`100% <100%> (ø)`	⬆️
tests/test_client_server.py	`100% <100%> (ø)`	⬆️
tests/test_protocol.py	`100% <100%> (ø)`	⬆️
src/websockets/__init__.py	`100% <100%> (ø)`	⬆️
src/websockets/framing.py	`100% <100%> (ø)`	⬆️
tests/test_framing.py	`100% <100%> (ø)`	⬆️
tests/__init__.py	`100% <100%> (ø)`
src/websockets/client.py	`100% <100%> (ø)`	⬆️
src/websockets/protocol.py	`100% <100%> (ø)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d723227...d75d4a4. Read the comment docs.

The bugs that were locking us on an old version are fixed.

* Don't pass the deprecated loop argument. * Ignore deprecation warnings for @asyncio.coroutine.

Since version 7.0, when the server closes, it terminates connections with close code 1001 instead of canceling them.

WebSocketCommonProtocol.transport can be unset, but it cannot be None.

stonebig · 2019-10-13T09:13:43Z

could we have a dev wheel on Pypi for Python-3.8rc1 ?

aaugustin · 2019-10-13T18:44:00Z

Yeah, I should do that => #681

aaugustin added 13 commits October 5, 2019 11:52

Copy FlowControlMixin and StreamReaderProtocol.

fbab68f

This is the official recommendation of Python core devs. The code is taken from the current 3.7 branch.

Remove docstrings and debug logs.

5790733

Merge FlowControlMixin in StreamReaderProtocol.

53523d0

Deduplicate loop and _loop attributes.

e6d8bcf

Remove client_connected callback.

4205cb1

Deduplicate reader/writer and _stream_reader/writer attributes.

2ebb4b4

Merge asyncio.Protocol methods.

c7ae53f

Finish merging StreamReaderProtocol and FlowControlMixin.

ab5dd72

Deduplicate connection termination tracking.

080543c

Remove unused attribute.

284932f

Ignore quality checks for code copied from asyncio.

9eeeeb3

Remove asyncio.StreamWriter.

f79cdd8

It adds only one method for flow control. Copy it, as we've already copied the rest of the flow control implementation.

Rename writer to write.

c55f374

It's a better name for a function that writes bytes.

aaugustin added 2 commits October 5, 2019 15:50

Update to the latest version of mypy.

3e03d1a

The bugs that were locking us on an old version are fixed.

Fix deprecation warnings on Python 3.8.

aef1e87

* Don't pass the deprecated loop argument. * Ignore deprecation warnings for @asyncio.coroutine.

aaugustin changed the title ~~Replace public APIs dropped by asyncio in Python 3.8~~ Add support for Python 3.8 Oct 5, 2019

Document and test support for Python 3.8.

504c66c

aaugustin force-pushed the replace-public-apis-dropped-silently-by-asyncio branch from 2e0a52b to 504c66c Compare October 5, 2019 14:06

aaugustin added 4 commits October 5, 2019 21:19

Move test logging configuration to a single place.

fc99c16

Remove test that no longer makes sense.

91dea74

Since version 7.0, when the server closes, it terminates connections with close code 1001 instead of canceling them.

Fix refactoring error.

88073fe

WebSocketCommonProtocol.transport can be unset, but it cannot be None.

Remove useless type declaration.

d75d4a4

aaugustin merged commit 154c5fa into master Oct 5, 2019

aaugustin deleted the replace-public-apis-dropped-silently-by-asyncio branch October 5, 2019 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Python 3.8 #675

Add support for Python 3.8 #675

aaugustin commented Oct 5, 2019

codecov bot commented Oct 5, 2019 •

edited

Loading

stonebig commented Oct 13, 2019

aaugustin commented Oct 13, 2019

Add support for Python 3.8 #675

Add support for Python 3.8 #675

Conversation

aaugustin commented Oct 5, 2019

codecov bot commented Oct 5, 2019 • edited Loading

Codecov Report

stonebig commented Oct 13, 2019

aaugustin commented Oct 13, 2019

codecov bot commented Oct 5, 2019 •

edited

Loading