Rawlink a callback on transaction completion#224
Closed
harlowja wants to merge 4 commits into
Closed
Conversation
Instead of assuming that a transaction will correctly complete before it actually does we should be smarter about this and inspect the result to determine if it actually did and only if it did should we set the committed flag. Fixes issue 222
openstack-gerrit
pushed a commit
to openstack/taskflow
that referenced
this pull request
Aug 30, 2014
To ensure we reliably handle when a transaction fails we should use the checked_commit() helper function instead of the currently not fully exception handling kazoo transaction commit function. This should be addressed in the future with: - python-zk/kazoo#224 - python-zk/kazoo#225 Those have not merged yet (or been released) so we need to use a similar function in the meantime. Change-Id: Icf83b7d4955c11227e733287170a7bd3ab372bd2
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 30, 2014
Project: openstack/taskflow 70d9199ea374b558a9918089de94af0b6c76811b Use checked_commit() around consume() and abandon() To ensure we reliably handle when a transaction fails we should use the checked_commit() helper function instead of the currently not fully exception handling kazoo transaction commit function. This should be addressed in the future with: - python-zk/kazoo#224 - python-zk/kazoo#225 Those have not merged yet (or been released) so we need to use a similar function in the meantime. Change-Id: Icf83b7d4955c11227e733287170a7bd3ab372bd2
|
👍 on the principle. This fixes a related issue that |
Member
|
Please re-open to rebase and update as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming that a transaction will
correctly complete before it actually does we
should be smarter about this and inspect the
result to determine if it actually did and only
if it did should we set the committed flag.
Fixes issue #222