sprinkled a few DebuggerHidden to make debugging easier

lostmsu · lostmsu · commit 82d6c33b0dc5 · 2021-10-29T19:09:34.000-07:00
diff --git a/src/runtime/NewReference.cs b/src/runtime/NewReference.cs
@@ -1,6 +1,7 @@
 namespace Python.Runtime
 {
     using System;
+    using System.Diagnostics;
     using System.Diagnostics.Contracts;
     using System.Runtime.CompilerServices;
 
@@ -83,6 +84,7 @@ public StolenReference Steal()
         }
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        [DebuggerHidden]
         public StolenReference StealOrThrow()
         {
             if (this.IsNull()) throw PythonException.ThrowLastAsClrException();
@@ -143,6 +145,7 @@ public static BorrowedReference BorrowNullable(this in NewReference reference)
         public static BorrowedReference Borrow(this in NewReference reference)
             => reference.IsNull() ? throw new NullReferenceException() : reference.BorrowNullable();
         [Pure]
+        [DebuggerHidden]
         public static BorrowedReference BorrowOrThrow(this in NewReference reference)
             => reference.IsNull() ? throw PythonException.ThrowLastAsClrException() : reference.BorrowNullable();
 
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -36,6 +36,7 @@ public PythonException(PyType type, PyObject? value, PyObject? traceback)
         /// It is recommended to call this as <code>throw ThrowLastAsClrException()</code>
         /// to assist control flow checks.
         /// </summary>
+        [DebuggerHidden]
         internal static Exception ThrowLastAsClrException()
         {
             // prevent potential interop errors in this method
@@ -416,6 +417,7 @@ internal static bool CurrentMatches(BorrowedReference ob)
             return Runtime.PyErr_ExceptionMatches(ob) != 0;
         }
 
+        [DebuggerHidden]
         internal static void ThrowIfIsNull(in NewReference ob)
         {
             if (ob.BorrowNullable() == null)
@@ -426,6 +428,7 @@ internal static void ThrowIfIsNull(in NewReference ob)
         internal static BorrowedReference ThrowIfIsNull(BorrowedReference ob)
             => Exceptions.ErrorCheck(ob);
 
+        [DebuggerHidden]
         internal static void ThrowIfIsNotZero(int value)
         {
             if (value != 0)

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`namespace Python.Runtime`
`2`	`2`	`{`
`3`	`3`	`using System;`
	`4`	`+ using System.Diagnostics;`
`4`	`5`	`using System.Diagnostics.Contracts;`
`5`	`6`	`using System.Runtime.CompilerServices;`
`6`	`7`
`@@ -83,6 +84,7 @@ public StolenReference Steal()`
`83`	`84`	`}`
`84`	`85`
`85`	`86`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
	`87`	`+ [DebuggerHidden]`
`86`	`88`	`public StolenReference StealOrThrow()`
`87`	`89`	`{`
`88`	`90`	`if (this.IsNull()) throw PythonException.ThrowLastAsClrException();`
`@@ -143,6 +145,7 @@ public static BorrowedReference BorrowNullable(this in NewReference reference)`
`143`	`145`	`public static BorrowedReference Borrow(this in NewReference reference)`
`144`	`146`	`=> reference.IsNull() ? throw new NullReferenceException() : reference.BorrowNullable();`
`145`	`147`	`[Pure]`
	`148`	`+ [DebuggerHidden]`
`146`	`149`	`public static BorrowedReference BorrowOrThrow(this in NewReference reference)`
`147`	`150`	`=> reference.IsNull() ? throw PythonException.ThrowLastAsClrException() : reference.BorrowNullable();`
`148`	`151`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ public PythonException(PyType type, PyObject? value, PyObject? traceback)`
`36`	`36`	`/// It is recommended to call this as <code>throw ThrowLastAsClrException()</code>`
`37`	`37`	`/// to assist control flow checks.`
`38`	`38`	`/// </summary>`
	`39`	`+ [DebuggerHidden]`
`39`	`40`	`internal static Exception ThrowLastAsClrException()`
`40`	`41`	`{`
`41`	`42`	`// prevent potential interop errors in this method`
`@@ -416,6 +417,7 @@ internal static bool CurrentMatches(BorrowedReference ob)`
`416`	`417`	`return Runtime.PyErr_ExceptionMatches(ob) != 0;`
`417`	`418`	`}`
`418`	`419`
	`420`	`+ [DebuggerHidden]`
`419`	`421`	`internal static void ThrowIfIsNull(in NewReference ob)`
`420`	`422`	`{`
`421`	`423`	`if (ob.BorrowNullable() == null)`
`@@ -426,6 +428,7 @@ internal static void ThrowIfIsNull(in NewReference ob)`
`426`	`428`	`internal static BorrowedReference ThrowIfIsNull(BorrowedReference ob)`
`427`	`429`	`=> Exceptions.ErrorCheck(ob);`
`428`	`430`
	`431`	`+ [DebuggerHidden]`
`429`	`432`	`internal static void ThrowIfIsNotZero(int value)`
`430`	`433`	`{`
`431`	`434`	`if (value != 0)`