Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup typecode switch - IEnumerable and object cases #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
den-run-ai opened this issue Mar 12, 2017 · 2 comments
Closed

Cleanup typecode switch - IEnumerable and object cases #428

den-run-ai opened this issue Mar 12, 2017 · 2 comments

Comments

@den-run-ai
Copy link
Contributor

#427 (comment)
@den-run-ai den-run-ai mentioned this issue Mar 12, 2017
Merged
2 tasks
@filmor
Copy link
Member

filmor commented Mar 23, 2017

Reopen with description, please.

@filmor filmor closed this as completed Mar 23, 2017
@den-run-ai
Copy link
Contributor Author

2 options suggested by @vmuriart:

  1. Delete that section of code IEnumerable altogether or
  2. Delete typecode.Object.

The remaining typecodes are Empty, DBNull, Decimal and DateTime and i don't think any of those should be converted to PyList.
Also, I can't think of a situation in which the default branch of the switch would be hit because we have Typecode.Object defined; It would always be called instead of the default. This example is probably closer to how it should be written.

@den-run-ai den-run-ai reopened this Mar 23, 2017
@filmor filmor closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filmor @den-run-ai