Fix for random Travis test crashes with Python 2.7 on Mono #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n attempt to replace segfault with a more meaningful exception related to pythonnet#1060
Codecov Report
@@ Coverage Diff @@
## master #1061 +/- ##
==========================================
+ Coverage 86.42% 86.75% +0.33%
==========================================
Files 1 1
Lines 302 302
==========================================
+ Hits 261 262 +1
+ Misses 41 40 -1
Continue to review full report at Codecov.
|
filmor
approved these changes
Feb 26, 2020
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
…n attempt to replace segfault with a more meaningful exception (pythonnet#1061) related to pythonnet#1060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ongoing work on random test crashes on Python 2.7 on Mono
What does this implement/fix? Explain your changes.
I've added error checks to the test, whose start precedes crashing (
PyCheck_Iter_PyObject_IsIterable_ThreadingLock_Test). This might replace segfault with a more meaningful error message.Does this close any currently open issues?
Not yet, but it should help narrow down #1060