Correctly dispose the result of PyRun_String #1071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also changes a few members of
NewReference
type to make them work inPyRun_String
scenarioWhat does this implement/fix? Explain your changes.
This PR is motivated by an observation of a crash after
PyRunString.TestExec2
. It callsPythonEngine.Exec
, which in case of exception fails to decrefPyRun_String
result.I replace
PyRun_String
return type withNewReference
and handle it accordingly.NewReference
instance members replaced with extension methodsIn the process of making this change it was discovered, that members of
NewReference
should be moved to an extension class, because in regular instance membersthis
is passed by mutable reference (e.g. analogous toref NewReference
in C# orNewReference&
in C++),which requires any method calling this member to have a mutable reference to
NewReference
:Instead we do this:
This would be obsolete one day once dotnet/csharplang#1710 is released.
Does this close any currently open issues?
This might (unlikely) fix this test crash: https://ci.appveyor.com/project/pythonnet/pythonnet/builds/31115525/job/kkciw8xk5jaux5t7
Checklist