Remove unnecessary CheckExceptionOccurred calls
#1175
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 1 1
Lines 291 291
=======================================
Hits 251 251
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
src/runtime/converter.cs
Outdated
| @@ -758,7 +758,10 @@ private static bool ToPrimitive(IntPtr value, Type obType, out object result, bo | |||
| goto type_error; | |||
| } | |||
| double dd = Runtime.PyFloat_AsDouble(op); | |||
| Runtime.CheckExceptionOccurred(); | |||
| if (dd == -1.0) | |||
There was a problem hiding this comment.
Knowing the funny behavior of floating-point comparisons, it would be good to have two test cases for this conversion passing and failing.
appveyor.yml
Outdated
| @@ -40,6 +40,7 @@ init: | |||
| install: | |||
| - python -m pip install -U pip | |||
| - pip install --upgrade -r requirements.txt --quiet | |||
| - pip install install pycparser --quiet | |||
There was a problem hiding this comment.
Yes, apparently it's wrong, never thought it works.😂
This line is due to requirements.txt declared won't pycparser be install on windows, but setup process need it.
|
I'd prefer the |
|
What does this implement/fix? Explain your changes.
Fro saving unnecessary costs.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG