Pybuffer #1195
Pybuffer #1195
Conversation
|
@filmor I took this one. After rebasing I just had to bring back a property on the runtime which we removed. It used to be public but I brought it back as internal. |
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 1 1
Lines 291 291
=======================================
Hits 251 251
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
src/runtime/runtime.cs
Outdated
| //"3.0a5+ (py3k:63103M, May 12 2008, 00:53:55) \n[GCC 4.2.3]" | ||
|
|
||
| //we only support python 3 so we just need to check the third character | ||
| return 30 + Convert.ToInt32(versionString[2]); |
There was a problem hiding this comment.
This seems very brittle to me, there must be a better solution. Also, we don't support any Python version before 3.5, so checks for that can go.
There was a problem hiding this comment.
@filmor I could use sys.version_info but I'd rather not run python code. Let me look for a C API equivalent
|
@lostmsu please review |
What does this implement/fix? Explain your changes.
Rebase of https://github.com/pythonnet/pythonnet/pull/980/files
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG