Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Python 3.9 #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Python 3.9 #1264

merged 6 commits into from
Nov 13, 2020

Conversation

filmor
Copy link
Member

@filmor filmor commented Oct 14, 2020

What does this implement/fix? Explain your changes.

Adds Python 3.9 to CI.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@filmor
Copy link
Member Author

filmor commented Oct 14, 2020

We'll have to wait until 3.9 is available in both Travis and Appveyor.

@filmor
Copy link
Member Author

filmor commented Oct 14, 2020

Waiting for
[ ] appveyor/ci#3541
[ ] https://travis-ci.community/t/python-3-9-0-build/10091 (Discussion)

@domdfcoding
Copy link

Python 3.9 is now available on Travis

- Only record structs when they are defined, not when they are declared
- If a struct was only declared when a typedef was created, it won't
  contain its member declarations. Those have to be drawn from the
  recorded structs instead.
- Rename internal members of AstParser to make it easier to debug
@filmor filmor changed the title Add Python 3.9 to CI Python 3.9 Nov 13, 2020
@filmor
Copy link
Member Author

filmor commented Nov 13, 2020

@lostmsu This is passing tests now, feel free to review. I'll backport this to 2.5.

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #1264 (a1316a1) into master (36bdb98) will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   87.62%   87.97%   +0.34%     
==========================================
  Files           1        1              
  Lines         291      291              
==========================================
+ Hits          255      256       +1     
+ Misses         36       35       -1     
Flag Coverage Δ
setup_linux 65.29% <ø> (+0.34%) ⬆️
setup_windows 74.22% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 87.97% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bdb98...a1316a1. Read the comment docs.

Copy link
Member

@lostmsu lostmsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe removing underscore from most members of gen_interop is a bit destructive to file's blame.

I'd also squash.

@filmor
Copy link
Member Author

filmor commented Nov 13, 2020

I'll clean things up a bit, but if I ever need to debug this again, I want the double-underscores already gone ;)

@filmor filmor merged commit 6be3636 into master Nov 13, 2020
filmor added a commit that referenced this pull request Nov 13, 2020
* Add Python 3.9 to CI
* Update AppVeyor image and always install all requirements
* Add Python 3.9 interop file
* Fix geninterop script and regenerate interop39.cs
    - Only record structs when they are defined, not when they are declared
    - If a struct was only declared when a typedef was created, it won't
      contain its member declarations. Those have to be drawn from the
      recorded structs instead.
   - Rename internal members of AstParser to make it easier to debug
@filmor filmor deleted the python3.9 branch January 23, 2021 11:30
@retheon
Copy link

retheon commented Feb 25, 2021

Hi, it seems this branch is already merged to master but here here it says that pythonnet does not support python 3.9. Does this page have to be updated or there is still a step I'm missing before python 3.9 is supported?

@filmor
Copy link
Member Author

filmor commented Feb 25, 2021

Things are complicated, check #1389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants