TestPythonEngineProperties.SetPythonPath avoids corrupting the module search path for later tests #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… search path for later tests
…under the new path
lostmsu
reviewed
Dec 22, 2020
There was a problem hiding this comment.
This seems fine. However, if you wanted this change to add a C# runner for Python tests, I suggest you turn the runner into a separate project file instead.
I'd also suggest to use something like https://stackoverflow.com/questions/866816/dynamically-create-tests-in-nunit to have the test display as individual tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Improves the test suite of Python.NET
Does this close any currently open issues?
Fixes #1335
Any other comments?
This change is not visible to the end user so it doesn't make sense to add it to the CHANGELOG.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG