Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix exception string #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 4 commits into from
Jan 29, 2021
Merged

Fix exception string #1360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ab234a
Check the stacktrace format in the unit test
filmor Jan 21, 2021
1819ba9
Fix exception stacktrace formatting
filmor Jan 21, 2021
5ae34ba
Add CHANGELOG entry
filmor Jan 21, 2021
ce61a6f
Reverse Python traceback to match C# stacktrace order
filmor Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check the stacktrace format in the unit test
  • Loading branch information
@filmor
filmor committed Jan 29, 2021
commit 1ab234a2ab4316d2398a87f5199de9228022ef05
16 changes: 15 additions & 1 deletion src/embed_tests/TestPythonException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,21 @@ public void TestPythonExceptionFormat()
}
catch (PythonException ex)
{
Assert.That(ex.Format(), Does.Contain("Traceback").And.Contains("(most recent call last):").And.Contains("ValueError: Error!"));
// Console.WriteLine($"Format: {ex.Format()}");
// Console.WriteLine($"Stacktrace: {ex.StackTrace}");
Assert.That(
ex.Format(),
Does.Contain("Traceback")
.And.Contains("(most recent call last):")
.And.Contains("ValueError: Error!")
);

// Check that the stacktrace is properly formatted
Assert.That(
ex.StackTrace,
Does.Not.StartWith("[")
.And.Not.Contain("\\n")
);
}
}

Expand Down