-
Notifications
You must be signed in to change notification settings - Fork 751
Support Python 3.6 #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.6 #310
Conversation
@cgohlke do you agree to transition from Zope to MIT license? |
Yes, I agree. |
@@ -3,7 +3,7 @@ | |||
|
|||
|
|||
|
|||
#if (PYTHON35) | |||
#if (PYTHON35 || PYTHON36) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a leftover from trying to reuse the file for Python 3.6. It is no longer needed. I'll remove this change. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only concern I had was already covered by @filmor and had been fixed.
Fixes #309 and #272 . Replaces #307.
Tested with Python 3.6 64-bit and msvc14 on Windows 10.