Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support Python 3.6 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 7, 2017
Merged

Support Python 3.6 #310

merged 6 commits into from
Jan 7, 2017

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Jan 5, 2017

Fixes #309 and #272 . Replaces #307.

Tested with Python 3.6 64-bit and msvc14 on Windows 10.

@den-run-ai
Copy link
Contributor

@cgohlke do you agree to transition from Zope to MIT license?

@cgohlke
Copy link
Contributor Author

cgohlke commented Jan 5, 2017

@cgohlke do you agree to transition from Zope to MIT license?

Yes, I agree.

@@ -3,7 +3,7 @@



#if (PYTHON35)
#if (PYTHON35 || PYTHON36)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a leftover from trying to reuse the file for Python 3.6. It is no longer needed. I'll remove this change. Thank you.

Copy link
Contributor

@vmuriart vmuriart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern I had was already covered by @filmor and had been fixed.

@filmor filmor merged commit 573f903 into pythonnet:master Jan 7, 2017
@vmuriart vmuriart mentioned this pull request Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants