Refactor setup.py #337
Merged
Refactor setup.py #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a3b249 to
f878786
Compare
tonyroberts
approved these changes
Jan 30, 2017
Replace one check_output to check_call since we don't use the output.
Use context manager for closing registries
self.announce is based on an incomplete logger. use debug_print that turns on when env_var DISTUTILS_DEBUG is present
f878786 to
6521033
Compare
Codecov Report
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Cleans up
setup.pyby using newer syntax/build-inClarifies the naming of platform/arch
Simplifies registry search with context managers
Fixes
self.announce(...)not announcing anything. It can be enabled now with environment variableDISTUTILS_DEBUGDoes this close any currently open issues?
Can help debug other issues with
announcenow working.Any other comments?
Slight clean up applied to
geninterop. tested generation working on all version of python supported.setup.pyis mostly pep8 compliant now