Fix Console config, Add pyproj, Add PY3 to configurationmanager #346
Conversation
Codecov Report@@ Coverage Diff @@
## master #346 +/- ##
=========================================
- Coverage 61.55% 60.85% -0.7%
=========================================
Files 61 57 -4
Lines 5264 5089 -175
Branches 885 852 -33
=========================================
- Hits 3240 3097 -143
+ Misses 1805 1773 -32
Partials 219 219
Continue to review full report at Codecov.
|
1234e3a to
8fe3f83
Compare
| @@ -31,7 +31,7 @@ install: | |||
| script: | |||
| - export PYTHONPATH=`pwd`:$PYTHONPATH | |||
| - python src/tests/runtests.py | |||
| # - nunit-console src/embed_tests/bin/x64/ReleaseMono/Python.EmbeddingTest.dll | |||
| # - nunit-console src/embed_tests/bin/Python.EmbeddingTest.dll | |||
There was a problem hiding this comment.
It runs the tests but all say Cant find python.runtime error. Didn't have a chance to debug it. I'm keeping the tests paths updated though
There was a problem hiding this comment.
Okay, fine by me then, but I'll open an issue for this, we should really start running those tests.
There was a problem hiding this comment.
On appveyor, when we run them on py3 they freeze and hang the testrunner until the build bot times out (30 minutes or so?).
I stress tested it on PY27 and its def fixed there. Ran 10 times no issues.
There was a problem hiding this comment.
@filmor if we downgrade back to nunit 2.6.2 we can start running the tests. They will still fail, but nunit will gracefully fail and give us the error instead of whatever nunit3 is doing now
Console had it owns set of properties going on
Corrected the configs, won't interfere with users without PTVS
Changed when consolidate output paths
What does this implement/fix? Explain your changes.
Standardizes build configurations across the projects (
Console.csprojhad its own thing going on)Adds @denfromufa 's *.pyproj with corrected configurations