Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add a scope class to manage the context of interaction with Python an… #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
den-run-ai merged 22 commits into from
Jun 9, 2017
Merged

add a scope class to manage the context of interaction with Python an… #381

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8e0b1a2
Deprecate public RunString
vmuriart Mar 3, 2017
72003aa
add a scope class to manage the context of interaction with Python an…
yagweb Feb 15, 2017
efd3798
Rename several methods and add three methods
yagweb Feb 23, 2017
9f50e25
rebased
yagweb Feb 24, 2017
add5ba8
Rebased update
vmuriart Feb 28, 2017
c15555c
format cleanup
vmuriart Feb 28, 2017
b0d57e9
create unnamed pyscope, make PyScope.GILState save
yagweb Mar 1, 2017
ceaaef0
fixup! create unnamed pyscope, make PyScope.GILState save
yagweb Mar 2, 2017
dec39c7
remove GIL and rebased
yagweb Mar 7, 2017
e117d60
Add several methods
yagweb Mar 7, 2017
904d9ed
add a Variables method
yagweb Mar 14, 2017
5484451
fixup! add a Variables method
yagweb Mar 15, 2017
2e063c2
remove private method _GetVariable
yagweb Mar 15, 2017
dd492f4
add unit test for Variables() method
yagweb Mar 15, 2017
df6a49a
add several methods and rebased
yagweb Apr 7, 2017
f35d75b
add a new class PyScopeManager
yagweb Apr 24, 2017
497d7aa
cleaned up the Import methods
yagweb Apr 28, 2017
60ce28b
Merge branch 'master' into add_scope
May 24, 2017
ebf5a2b
Merge branch 'master' into add_scope
May 24, 2017
2c3db3d
updated according to filmor's comments
yagweb May 31, 2017
30543eb
fixup! updated according to filmor's comments
yagweb May 31, 2017
b9dcdac
Get/Set Methods renamed
yagweb Jun 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! add a Variables method
  • Loading branch information
@yagweb
yagweb committed Apr 7, 2017
commit 5484451819e74bde7d7109523a8d88f09f2ca6a0
16 changes: 16 additions & 0 deletions src/runtime/pyscope.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ internal PyScope(string name)
variables, "__builtins__",
Runtime.PyEval_GetBuiltins()
);
InitVariables();
}

//To compitable with the python module
private void InitVariables()
{
SetVariable("locals", (Func<PyDict>)Variables);
SetVariable("globals", (Func<PyDict>)Variables);
Copy link
Copy Markdown
Member

@filmor filmor Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said before, I'm strongly against this. I don't see any advantage in this over separating globals and locals as done in the Python API.

Copy link
Copy Markdown
Contributor Author

@yagweb yagweb Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the responses below.

}
Expand All @@ -50,10 +56,19 @@ internal PyScope(string name)
/// </summary>
internal IntPtr variables { get; private set; }

public long Refcount
Copy link
Copy Markdown
Member

@filmor filmor Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this one for?

Copy link
Copy Markdown
Contributor Author

@yagweb yagweb Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for debug, now there are 2 IntPtr in the PyScope and the code seems stable, so it was removed.

{
get
{
return Runtime.Refcount(variables);
}
}

public event Action<PyScope> OnDispose;
Copy link
Copy Markdown
Member

@filmor filmor Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use-case for this?

Copy link
Copy Markdown
Contributor Author

@yagweb yagweb Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyScopes are managed by Py class, when it was disposed, Py class can do some cleaning work through registering this event.

In the future, methods in Py class maybe put in an independent ScopeManager class, see the responses below.


public PyDict Variables()
{
Runtime.XIncref(variables);
return new PyDict(variables);
}

Expand All @@ -77,6 +92,7 @@ public void ImportScope(PyScope scope)
{
throw new PythonException();
}
InitVariables();
}

/// <summary>
Expand Down