Codecov Report

Merging #403 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #403      +/-   ##
=========================================
+ Coverage   63.38%   63.5%   +0.11%     
=========================================
  Files          61      61              
  Lines        5277    5264      -13     
  Branches      863     861       -2     
=========================================
- Hits         3345    3343       -2     
+ Misses       1713    1701      -12     
- Partials      219     220       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a35cb...5b3f58a. Read the comment docs.

@vmuriart isn't explicit better than implicit? Can you at least add the docs which show the default calling conventions?

Each commit message has a reference to the links.

sorry, i still don't see any links. this SO answer mentions to declare cdecl: http://stackoverflow.com/a/15664100/2230844

I just realized you asked for the callingconventions one specifically, looks like i skipped that one sorry.
https://msdn.microsoft.com/en-us/library/system.runtime.interopservices.callingconvention(v=vs.110).aspx

In terms of explicit vs implicit. It's way overengineered, and makes the code less legible. I am all for including them if they are necessary but in most cases they aren't. Fixing the marshal issue became alot simpler after I completed this pr because it made alot more sense where we were actually needing to use it.

CallingConvention is the only one I am still debating if we actually need to keep. It seems that for our use case it isn't necessary, but I'm ok removing that part from this pr and revisiting it later.

http://stackoverflow.com/a/6511236/5208670 suggest that we are ok without it. None of the calls python API that I've seen have vargs, and those that may we can add the calling convention to them (and would distinguish them from the rest)

BTW, default calling convention for pinvoke is stdcall, but cdecl is more compatible across various compilers.