-
Notifications
You must be signed in to change notification settings - Fork 750
Implement named arguments and With semantics in C# embedding side #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
73c40fc
Added python "with" construction
dsuarezv 500d3d3
Added some unit tests for new With method
dsuarezv 35a7dc6
Renamed With tests for easier grouping
dsuarezv c3c1c56
Support for named arguments to invoke python methods
dsuarezv 6c27e84
Named argument tests cosmetic changed
dsuarezv a31c590
Merge branch 'master' into missing_func
filmor 66864ad
Fixed failing test in python 2.7
dsuarezv 93b1bda
Reset line endings in csproj to LF
dsuarezv 9f1c378
Merge branch 'master' into missing_func
dsuarezv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Added python "with" construction
- Loading branch information
commit 73c40fc6d484acaed68514955963a5512d086739
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
using System; | ||
using NUnit.Framework; | ||
using Python.Runtime; | ||
|
||
namespace Python.EmbeddingTest | ||
{ | ||
public class TestPyWith | ||
{ | ||
[OneTimeSetUp] | ||
public void SetUp() | ||
{ | ||
PythonEngine.Initialize(); | ||
} | ||
|
||
[OneTimeTearDown] | ||
public void Dispose() | ||
{ | ||
PythonEngine.Shutdown(); | ||
} | ||
|
||
/// <summary> | ||
/// Test that exception is raised in context manager that ignores it. | ||
/// </summary> | ||
[Test] | ||
public void TestPositiveWith() | ||
{ | ||
var locals = new PyDict(); | ||
|
||
PythonEngine.Exec(@" | ||
class cmTest: | ||
def __enter__(self): | ||
print('Enter') | ||
return self | ||
def __exit__(self, t, v, tb): | ||
# Exception not handled, return will be False | ||
print('Exit') | ||
def fail(self): | ||
return 5 / 0 | ||
|
||
a = cmTest() | ||
", null, locals.Handle); | ||
|
||
var a = locals.GetItem("a"); | ||
|
||
try | ||
{ | ||
Py.With(a, cmTest => | ||
{ | ||
cmTest.fail(); | ||
}); | ||
} | ||
catch (PythonException e) | ||
{ | ||
Assert.IsTrue(e.Message.Contains("division by zero")); | ||
} | ||
} | ||
|
||
|
||
/// <summary> | ||
/// Test that exception is not raised in context manager that handles it | ||
/// </summary> | ||
[Test] | ||
public void TestNegativeWith() | ||
{ | ||
var locals = new PyDict(); | ||
|
||
PythonEngine.Exec(@" | ||
class cmTest: | ||
def __enter__(self): | ||
print('Enter') | ||
return self | ||
def __exit__(self, t, v, tb): | ||
# Signal exception is handled by returning true | ||
return True | ||
def fail(self): | ||
return 5 / 0 | ||
|
||
a = cmTest() | ||
", null, locals.Handle); | ||
|
||
var a = locals.GetItem("a"); | ||
Py.With(a, cmTest => | ||
{ | ||
cmTest.fail(); | ||
}); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CmTest
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filmor what do you mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python convention for classes is
CamelCase
.