Catching exceptions from iterator MoveNext() (related to #475) #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickardraysearch, thanks! @vmuriart, @brianlloyd, @tiran, @ArvidJB and @filmor, please review this. |
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
========================================
- Coverage 77.12% 76% -1.12%
========================================
Files 65 63 -2
Lines 5547 5476 -71
Branches 889 878 -11
========================================
- Hits 4278 4162 -116
- Misses 981 1001 +20
- Partials 288 313 +25
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Catches exceptions in iterator MoveNext() and throws them in python instead of crashing.
Does this close any currently open issues?
Issue #475.
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG