Fixed problem with --xplat build when mono does not installed. #572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 77.14% 77.07% -0.07%
==========================================
Files 65 65
Lines 5617 5623 +6
Branches 888 888
==========================================
+ Hits 4333 4334 +1
- Misses 996 1001 +5
Partials 288 288
Continue to review full report at Codecov.
|
| @@ -281,7 +281,13 @@ def _get_manifest(self, build_dir): | |||
| return manifest | |||
|
|
|||
| def _build_monoclr(self): | |||
| mono_libs = _check_output("pkg-config --libs mono-2", shell=True) | |||
| try: | |||
There was a problem hiding this comment.
I think the mono cflags check should be in the try block as well - it also throws in the same way, I believe
There was a problem hiding this comment.
@dmitriyse is this not failing in CI because both Mono and .NET Core are available?
There was a problem hiding this comment.
Yes, --xplat was working in CI only due to both frameworks installed.
73d3282 to
9d25e9c
Compare
|
I can confirm that I am able to successfully build using this branch, although tests still fail, and nPython doesn't really work either, as per #571 comments |
|
@Cronan so you can build pythonnet for .NET Core without Mono installed on this Linux machine? |
|
@denfromufa yes, I can build pythonnet for .NET Core without Mono installed on RH Linux Enterprise 7.3 (using the code in this PR) |
|
ok, I'm merging this pull request, thanks @dmitriyse @Cronan ! |
What does this implement/fix? Explain your changes.
Fixes --xplat build when no mono available.
...
Does this close any currently open issues?
#571
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG