fixed bug of Exec method #591 #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@yagweb looks great! let's wait for one more approval. the tests on appveyor fail for 2 environments due to github connection failure with OpenSSL. so nothing to worry about! |
den-run-ai
approved these changes
Jan 11, 2018
filmor
approved these changes
Jan 11, 2018
Member
filmor
left a comment
There was a problem hiding this comment.
I dislike Python's default here, but it is good to be consistent with it, thanks for the patch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR makes the RunString method acts just like the exec/eval method in CPython.
In CPython, the default value of parameter 'locals' of exec/eval method is obtained by calling the method locals() when its given value is None. So only when the exec/eval method is called in a function, the default value of parameter 'locals' is different from the value of 'globals'.
Since in pythonnet the Eval/Exce method can only be called from the global/module scope, it meaningful to directly set the value of locals to the value of globals when it is null.
...
Does this close any currently open issues?
#591
...
Any other comments?
No.
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG