Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix for "handle is not inialized" crash on clr.GetClrType(System.__class__) #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

den-run-ai
Copy link
Contributor

What does this implement/fix? Explain your changes.

fix for "handle is not initalized" crash on clr.GetClrType(System.__class__)

Does this close any currently open issues?

#606

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov
Copy link

codecov bot commented Jan 28, 2018

Codecov Report

Merging #607 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   77.01%   76.98%   -0.03%     
==========================================
  Files          64       64              
  Lines        5607     5609       +2     
  Branches      887      888       +1     
==========================================
  Hits         4318     4318              
- Misses       1001     1002       +1     
- Partials      288      289       +1
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.16% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
src/runtime/managedtype.cs 46.15% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ec24c...19ec822. Read the comment docs.

Copy link
Contributor

@dmitriyse dmitriyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. There are nothing to improve.

@den-run-ai
Copy link
Contributor Author

@dmitriyse merging according to new rules, since no objection is received

@den-run-ai den-run-ai merged commit 9333d77 into master Jan 31, 2018
@filmor filmor deleted the getclrtype branch May 28, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants