Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed errors breaking .NET Remoting on method invoke (#276) #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

den-run-ai
Copy link
Contributor

What does this implement/fix? Explain your changes.

#276

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@den-run-ai
Copy link
Contributor Author

@callumnoble @jcarole this PR for .NET Remoting cannot be merged, because more general solution that would work on .NET Core is necessary. .NET Remoting is deprecated and its API is not available in .NET Core and .NET Standard.

@jcarole
Copy link

jcarole commented Feb 26, 2018

@denfromufa Just to confirm, does this mean that Pythonnet 2.0.0 will be the last version that supports .NET Remoting?

@callumnoble
Copy link
Contributor

For my application which needs this I'm deploying a wheel I built with 2.3 + this patch. Is working well.

I see the fails from the CI build. Would you support an #if / #endif conditional for building .NET with version that supports remoting. By definition this check does not need to run on .NET Core since the remoting the library uses wont have been able to run on it!

The same define as used here could work?

#if NETSTANDARD

@den-run-ai
Copy link
Contributor Author

den-run-ai commented Feb 26, 2018

@callumnoble that looks reasonable, would you like to make this commit? you can open a new PR if needed.

@jcarole
Copy link

jcarole commented Feb 26, 2018

@denfromufa @callumnoble Exactly. Since .NET Remoting isn't supported by .NET Core (yet, and probably ever), a conditional compilation solution seems ideal.

@callumnoble
Copy link
Contributor

Will look into doing this sometime in the next few days.

@callumnoble
Copy link
Contributor

@denfromufa opened new pr for this #637

@den-run-ai den-run-ai closed this Mar 2, 2018
@filmor filmor deleted the pr/631 branch May 28, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants