Adds method name to "no method matches" error #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
- Coverage 76.83% 72.48% -4.36%
==========================================
Files 64 64
Lines 5587 5583 -4
Branches 891 889 -2
==========================================
- Hits 4293 4047 -246
- Misses 1003 1203 +200
- Partials 291 333 +42
Continue to review full report at Codecov.
|
filmor
requested changes
Jul 13, 2018
src/runtime/methodbinder.cs
Outdated
| @@ -507,7 +507,7 @@ internal virtual IntPtr Invoke(IntPtr inst, IntPtr args, IntPtr kw, MethodBase i | |||
|
|
|||
| if (binding == null) | |||
| { | |||
| Exceptions.SetError(Exceptions.TypeError, "No method matches given arguments"); | |||
| Exceptions.SetError(Exceptions.TypeError, $"No method matches given arguments for {methodinfo[0].Name}"); | |||
There was a problem hiding this comment.
How do you know that methodinfo is not null and that it contains at least one element?
There was a problem hiding this comment.
Right, I will add a check for null and at least one element.
Thank you. I didn't came across those conditions in my application.
filmor
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When a method does not find a match for given arguments, the thrown runtime error message does not informs us which method call failed.
Does this close any currently open issues?
No.
Any other comments?
No.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG