Fix memory leak in finalizer #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `finalizer` was leaking `_pendingArgs` (global memory) when the call to `Py_AddPendingCall` was unsuccessful. - Changing `lock` for `Monitor.TryEnter` at `AddPendingCollect()` so threads don't block each other.
|
Thank you very much for this, I was already starting to rebase the PR from the fork :) |
|
Sure! thank you, happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
finalizerwas leaking_pendingArgs(global memory) when the callto
Py_AddPendingCallwas unsuccessful.lockforMonitor.TryEnteratAddPendingCollect()sothreads don't block each other.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG