Readd .NET implementations of GC slots again #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I failed to provide properly working implementations of Return0 and Return1 for ARM, I'll just add the old behaviour back for all platforms but x86 and amd64.
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 76.25% 76.18% -0.07%
==========================================
Files 65 65
Lines 6030 6010 -20
Branches 990 991 +1
==========================================
- Hits 4598 4579 -19
+ Misses 1099 1098 -1
Partials 333 333
Continue to review full report at Codecov.
|
|
Looks like this would work except for codecov |
|
Yes, I still think this is a good idea, but it sadly didn't fix #898 as a I hoped it would... |
4 tasks
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 18, 2020
Since I failed to provide properly working implementations of Return0 and Return1 for ARM, I'll just add the old behaviour back for all platforms but x86 and amd64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I failed to provide properly working implementations of Return0 and Return1 for ARM, I'll just add the old behaviour back for all platforms but x86 and amd64.
Does this close any currently open issues?
#898