Detect py arch #961
Merged
Detect py arch #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
requested changes
Sep 26, 2019
| else | ||
| // Couldn't determine interpreter arch, try 64 bit | ||
| return PyLong_FromUnsignedLong64(Convert.ToUInt64(value)); | ||
| } |
There was a problem hiding this comment.
This is kind of fine, just use the already provided Runtime.Is32Bit and Runtime.IsWindows instead.
|
Thanks for the contribution, the fix to the forwarded functions should do the trick, just use the already existing properties instead of trying to draw this from Python :) |
amos402
reviewed
Sep 27, 2019
filmor
approved these changes
Oct 1, 2019
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 27, 2020
* Gets size of C long from Is32Bit and IsWindows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
As described in Issue #950, the size of python's longs can vary depending on platform. This changes allows pythonnet to determine at runtime the architecture of the python interpreter and select the correct size of long/int for the affected methods.
Does this close any currently open issues?
#950
Any other comments?
No
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG