Thanks to visit codestin.com
Credit goes to github.com

Skip to content

updated documentation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 14, 2016
Merged

updated documentation #5

merged 10 commits into from
Sep 14, 2016

Conversation

den-run-ai
Copy link
Contributor

No description provided.

@den-run-ai
Copy link
Contributor Author

den-run-ai commented Sep 13, 2016

@filmor @vmuriart @tonyroberts please review documentation update. The motivation was outdated information on python guide referencing these docs:

https://github.com/kennethreitz/python-guide/pull/746

@tonyroberts
Copy link
Contributor

👍

@filmor
Copy link
Member

filmor commented Sep 13, 2016

Just one small thing: Do we really want people to use npython? Does that make sense at all, seeing that it's completely equivalent to running python and then importing clr?

@den-run-ai
Copy link
Contributor Author

@filmor npython is still useful for quickly troubleshooting the embedding cases:

https://github.com/pythonnet/pythonnet/search?q=npython&type=Issues

Also @cgohlke still bundles npython.exe in his wheels:

http://www.lfd.uci.edu/~gohlke/pythonlibs/#pythonnet

@tonyroberts
Copy link
Contributor

@denfromufa I agree with @filmor that it's better for new users to be pointed to the regular python instead of nPython, otherwise they might get the impression somehow using pythonnet requires npython. What about changing it to python, and adding a note that nPython is available as an example of embedding the CPython interpreter in a c# application?

@den-run-ai
Copy link
Contributor Author

Agreed! Let me change the purpose of nPython.exe in these docs from "using
pythonnet" to "example of embedding Python in .NET". The primary way to use
pythonnet should be "import clr" in python/ipython interpreter.

On Tue, Sep 13, 2016 at 10:03 AM, Tony Roberts [email protected]
wrote:

@denfromufa https://github.com/denfromufa I agree with @filmor
https://github.com/filmor that it's better for new users to be pointed
to the regular python instead of nPython, otherwise they might get the
impression somehow using pythonnet requires npython. What about
changing it to python, and adding a note that nPython is available as an
example of embedding the CPython interpreter in a c# application?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5S9gdlOhAIFP7-NIc2HlVDtTG-vPks5qprtJgaJpZM4J7QJD
.

@den-run-ai
Copy link
Contributor Author

@tonyroberts @filmor done! please go through a second round of review.

@filmor
Copy link
Member

filmor commented Sep 14, 2016

Looks good to me.

@tonyroberts
Copy link
Contributor

me too

@filmor
Copy link
Member

filmor commented Sep 14, 2016

Then squash and merge :)

@filmor filmor merged commit 27d3982 into master Sep 14, 2016
@filmor filmor deleted the denfromufa-documentation branch September 14, 2016 15:08
@den-run-ai
Copy link
Contributor Author

I started working on draft release notes. Let's mark all issues to be
resolved for this release.

On Wed, Sep 14, 2016 at 10:08 AM, Benedikt Reinartz <
[email protected]> wrote:

Merged #5 #5.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5VVqMSjOPnkZIrnxV1JrkSuyRiCxks5qqA3ugaJpZM4J7QJD
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants