Prepare for -DPy_LIMITED_API flag in pytorch #145764#1627
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1627
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 1be90e8 with merge base 47f96f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
reviewed
Jan 27, 2025
| "-O3" if not debug_mode else "-O0", | ||
| "-fdiagnostics-color=always", | ||
| ] | ||
| extra_compile_args["cxx"].extend( |
drisspg
approved these changes
Jan 27, 2025
|
|
||
| current_date = datetime.now().strftime("%Y%m%d") | ||
|
|
||
| PY3_9_HEXCODE = "0x03090000" |
Contributor
There was a problem hiding this comment.
this strange AF to me as a flag
Contributor
Author
There was a problem hiding this comment.
lol yea welcome to the undocumented world of python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch core is going to start enforcing the Py_LIMITED_API flag definition for best practices + sanity whenever the py_limited_api is passed in. This PR prepares AO to smoothly handle that change when the nightly is updated.
PT PR: pytorch/pytorch#145764
Test plan:
This should be a noop for both build and runtime.