Parametrize quantization APIs for AWQ unittest #2930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2930
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@jerryzh168 @Xia-Weiwen Sorry for the interruption, could you review this PR? |
jerryzh168
approved these changes
Sep 13, 2025
jerryzh168
reviewed
Sep 13, 2025
test/prototype/test_awq.py
Outdated
| base_config = Int4WeightOnlyConfig() | ||
| class TestAWQ(common_utils.TestCase): | ||
| @common_utils.parametrize("base_config", [Int4WeightOnlyConfig()]) | ||
| def test_awq_config(self, base_config): |
There was a problem hiding this comment.
this one is fine not to parametrize I think
jerryzh168
reviewed
Sep 13, 2025
test/prototype/test_awq.py
Outdated
| @@ -61,19 +58,20 @@ def test_awq_config(self): | |||
| with self.assertRaisesRegex(ValueError, "is not one of"): | |||
| AWQConfig(base_config, step="not_supported") | |||
|
|
|||
| def test_awq_functionality(self): | |||
| @common_utils.parametrize( | |||
| "base_config", [Int4WeightOnlyConfig(group_size=128, version=2)] | |||
There was a problem hiding this comment.
nit: version=2 can be removed now
jerryzh168
reviewed
Sep 13, 2025
test/prototype/test_awq.py
Outdated
| @@ -104,12 +102,14 @@ def test_awq_functionality(self): | |||
| loss_base = (ref_out - baseline_out).pow(2).mean().item() | |||
| assert loss_awq < loss_base | |||
|
|
|||
| def test_awq_loading(self): | |||
| @common_utils.parametrize( | |||
| "base_config", [Int4WeightOnlyConfig(group_size=128, version=2)] | |||
There was a problem hiding this comment.
same here, version=2 can be removed now
jerryzh168
reviewed
Sep 13, 2025
test/prototype/test_awq.py
Outdated
| @@ -152,7 +151,10 @@ def test_awq_loading(self): | |||
| assert awq_save_load_out is not None | |||
| assert torch.allclose(awq_out, awq_save_load_out, atol=1e-2) | |||
|
|
|||
| def test_awq_loading_vllm(self): | |||
| @common_utils.parametrize( | |||
| "base_config", [Int4WeightOnlyConfig(group_size=128, version=2)] | |||
|
Not sure how was #2997 merged into main, destroying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For expanding more quantization API tests, parameterize quantization APIs in the AWQ unittest, preserving structure.
Test plan: CI -
test/prototype/test_awq.py