Thanks to visit codestin.com
Credit goes to github.com

Dependency refactor, add tests#1165

Closed

lucylq wants to merge 1 commit into

pytorch:mainfrom

lucylq:export-D51036567

lucylq commented Nov 7, 2023

Contributor

Summary:
Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

New dep chain:
op_.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

Old dep chain:
op_.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

Testing
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

pytorch-bot Bot commented Nov 7, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1165

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d52379 with merge base bfebeda ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

facebook-github-bot commented Nov 7, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

facebook-github-bot added the fb-exported label

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

adacaf1

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 0122f64 to adacaf1 Compare

November 7, 2023 22:30

facebook-github-bot commented Nov 7, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

a4a79fb

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from adacaf1 to a4a79fb Compare

November 7, 2023 22:31

facebook-github-bot commented Nov 7, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

c9a257e

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from a4a79fb to c9a257e Compare

November 8, 2023 05:33

facebook-github-bot commented Nov 8, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

37f89ba

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from c9a257e to 37f89ba Compare

November 8, 2023 05:34

facebook-github-bot commented Nov 8, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

0b08637

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 37f89ba to 0b08637 Compare

November 8, 2023 17:43

facebook-github-bot commented Nov 8, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

1 similar comment

facebook-github-bot commented Nov 8, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

e1304cf

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 0b08637 to e1304cf Compare

November 8, 2023 21:10

facebook-github-bot commented Nov 8, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

d114133

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from e1304cf to d114133 Compare

November 8, 2023 21:11

facebook-github-bot commented Nov 8, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

392aa29

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from d114133 to 392aa29 Compare

November 9, 2023 00:00

facebook-github-bot commented Nov 9, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

9995feb

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 392aa29 to 9995feb Compare

November 9, 2023 07:13

facebook-github-bot commented Nov 9, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

0005bbd

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 9995feb to 0005bbd Compare

November 9, 2023 07:14

facebook-github-bot commented Nov 9, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

6b497fa

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 0005bbd to 6b497fa Compare

November 9, 2023 07:44

facebook-github-bot commented Nov 9, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

a47a9f5

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 6b497fa to a47a9f5 Compare

November 9, 2023 07:45

facebook-github-bot commented Nov 9, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567


          Dependency refactor, add tests (pytorch#1165)

9d52379

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Gated to only run with fbcode, as there is dependency on exir which is only in fbcode.

Reviewed By: larryliu0820

Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from a47a9f5 to 18cca74 Compare

November 10, 2023 22:34

lucylq added a commit to lucylq/executorch-1 that referenced this pull request


          Dependency refactor, add tests (pytorch#1165)

18cca74

Summary:

Refactor dependency chain following:
https://docs.google.com/document/d/1vuU9UdQA5bq3WU7YnEgJowq9ey6vkF3KUKA0rpIxxIY/edit#heading=h.8raqyft9y50

**New dep chain:**
op_<op>.cpp -> selected_op_variants.h
selected_op_variants.h -> scalar_type_util

**Old dep chain:**
op_<op>.cpp -> scalar_type_util
scalar_type_util -> selected_op_variants.h

**Testing**
Add e2e test with addmul model
Update unit test to use addmul model

Gated to only run with fbcode, as there is dependency on exir which is only in fbcode.

Reviewed By: larryliu0820

Differential Revision: D51036567

facebook-github-bot commented Nov 10, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

lucylq force-pushed the export-D51036567 branch from 18cca74 to 9d52379 Compare

November 10, 2023 22:34

facebook-github-bot commented Nov 10, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D51036567

facebook-github-bot closed this in

f4679ae

facebook-github-bot added the Merged label

facebook-github-bot commented Nov 11, 2023

Contributor

This pull request has been merged in f4679ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged