Added ETDump to Wasm#13304
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13304
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ebeb7de with merge base 8e73c09 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
| if [ "$arg" == "--enable-etdump" ]; then | ||
| ETDUMP_OPTS="-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \ | ||
| -DEXECUTORCH_BUILD_DEVTOOLS=ON \ | ||
| -DFLATCC_ALLOW_WERROR=OFF" |
There was a problem hiding this comment.
Add a comment here on why this flag is required?
lucylq
left a comment
There was a problem hiding this comment.
LGTM, also cc @Gasoonjia on devtools
|
LGTM. |
I think all of the wasm work has been in OSS, so there aren't buck targets for it and it won't break CI. Conan and I had a quick look, and there is emscripten internally that we could use from fbsource/third-party if we wanted to buckify things cc @JacobSzwejbka |
### Summary Turning on the `EXECUTORCH_ENABLE_EVENT_TRACER` option will enable event tracing in the Wasm module API. The results can be obtained with the `etdump()` method. ### Test plan Added two tests depending on whether `EXECUTORCH_ENABLE_EVENT_TRACER` is turned on or not. Added the `--enable-etdump` option to `scripts/build_wasm_tests.sh` which turns on the above option. Added configurations to the `unittest-wasm-bindings` CI test to run with and without `--enable-etdump`.
Summary
Turning on the
EXECUTORCH_ENABLE_EVENT_TRACERoption will enable event tracing in the Wasm module API. The results can be obtained with theetdump()method.Test plan
Added two tests depending on whether
EXECUTORCH_ENABLE_EVENT_TRACERis turned on or not. Added the--enable-etdumpoption toscripts/build_wasm_tests.shwhich turns on the above option.Added configurations to the
unittest-wasm-bindingsCI test to run with and without--enable-etdump.