Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add bfloat16 to scalar_type.fbs#16882

Merged
lucylq merged 1 commit into
mainfrom
lfq.serialize-dataclass
Jan 26, 2026
Merged

Add bfloat16 to scalar_type.fbs#16882
lucylq merged 1 commit into
mainfrom
lfq.serialize-dataclass

Conversation

@lucylq

@lucylq lucylq commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This should cover all the scalar_type.fbs files: https://github.com/search?q=repo%3Apytorch%2Fexecutorch%20path%3Ascalar_type.fbs&type=code

Test plan

Deserialize a program with bfloat16. See: https://www.internalfb.com/manifold/explorer/executorch/tree/models/whisper/test/model.pte

>>> from executorch.exir._serialize import _deserialize_pte_binary
>>> f = open("model.pte", "rb")
>>> m = _deserialize_pte_binary(f.read())
>>>

@lucylq lucylq requested a review from JacobSzwejbka as a code owner January 26, 2026 19:04
Copilot AI review requested due to automatic review settings January 26, 2026 19:04
@lucylq lucylq requested a review from Gasoonjia as a code owner January 26, 2026 19:04
@pytorch-bot

pytorch-bot Bot commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16882

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 10 Pending

As of commit 99ca1a7 with merge base b729d35 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2026
@lucylq lucylq requested a review from larryliu0820 January 26, 2026 19:05
@github-actions

github-actions Bot commented Jan 26, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed Jan 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request activates the BFLOAT16 scalar type in the FlatBuffer schema files by uncomment it from the enum definition. The change enables deserialization of programs that use bfloat16 tensors.

Changes:

  • Activated BFLOAT16 enum value (15) in three scalar_type.fbs files
  • Removed commented-out BFLOAT16 entries from the "not implemented" section

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
schema/scalar_type.fbs Added BFLOAT16 = 15 enum entry and removed commented version
extension/flat_tensor/serialize/scalar_type.fbs Added BFLOAT16 = 15 enum entry and removed commented version
devtools/etdump/scalar_type.fbs Added BFLOAT16 = 15 enum entry and removed commented version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread schema/scalar_type.fbs
@lucylq lucylq force-pushed the lfq.serialize-dataclass branch from bef6493 to 99ca1a7 Compare January 26, 2026 19:11
@lucylq lucylq merged commit 61ae2f6 into main Jan 26, 2026
169 of 170 checks passed
@lucylq lucylq deleted the lfq.serialize-dataclass branch January 26, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucylq @larryliu0820