🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17085

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit e22e231 with merge base b698260 ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchbot label "release notes: none"

Hi @mohammed-saalim, changes look good. Thank you so much for adding this. Given the source of truth is in executorch/schema, could we move this test to https://github.com/pytorch/executorch/tree/main/schema/test?

made changes as suggested. @lucylq

Thanks @mohammed-saalim. I had a check and I think this isn't covered by CI because there weren't python tests in this directory before. Can you add the schema/ directory to pytest.ini, and keep an eye on the unittest ci jobs (e.g. unittest / linux / linux-job, and the macos/windows equivalents), to make sure it's running and passing?

For example, see the test: https://github.com/pytorch/executorch/actions/runs/21601350041/job/62247864130#step:16:15427

---------- coverage: platform linux, python 3.10.19-final-0 ----------
Coverage XML written to file coverage.xml

================ 1348 passed, 11 skipped in 2615.36s (0:43:35) =================

I guess we want to check that schema/test_schema.py appears in the logs.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)
devtools/bundled_program/schema/test/test_schema.py:1

• Removing this test file will leave the internal BUCK target at devtools/bundled_program/schema/test/BUCK with a python_unittest that still lists test_schema.py in srcs, which will cause that target to fail to build or run; please either update the BUCK rule to point at the new shared test under schema/test/test_schema.py or keep a thin wrapper test in this directory so the declared target remains valid.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mohammed-saalim sorry last one - can you also remove the BUCK target here? https://github.com/pytorch/executorch/blob/main/devtools/bundled_program/schema/test/BUCK#L12-L17

@lucylq my bad! i have removed it. Anything else?

@mohammed-saalim I think that's all good. Thanks for the edits and feel free to merge it once the tests are good 🎉

I don't think this should cause any test failures/github should indicate any flaky tests, but if there are you can check https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50 to see if it's an existing failure (that github didn't catch), or ping me to double check.

We may want to add a BUCK target to schema/test but I can do that in a follow-up and test with the internal buck build.

@mohammed-saalim seems like there's a linter issue, do you mind fixing it? You can fix it manually or install the lintrunner following: https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner

>>> Lint for devtools/bundled_program/schema/test/BUCK:

  Error (NEWLINE) Trailing newline
    Trailing newline found. Run `lintrunner --take NEWLINE -a` to apply
    changes.

    You can run `lintrunner -a` to apply this patch.

     7   7 | # !!!! fbcode/executorch/devtools/bundled_program/schema/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!
     8   8 | 
     9   9 | load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
     9     |-
    10     |-

+ echo ''

@lucylq The 3 failing checks appear to be infrastructure issues unrelated to my changes:

2 Windows build failures
ARM backend Docker container failure (was already flagged as flaky in the original PR)
The Lint check is now passing after fixing the trailing newline. Let me know if you'd like me to investigate further, but these seem to be pre-existing issues on trunk.

@mohammed-saalim merged. Thank you for your contribution!