Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Newly added lint-urls jobs are very flaky #152439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
malfet opened this issue Apr 29, 2025 · 10 comments
Open

Newly added lint-urls jobs are very flaky #152439

malfet opened this issue Apr 29, 2025 · 10 comments
Assignees
@huydhn
Labels
module: ci Related to continuous integration module: flaky-tests Problem is a flaky test in CI module: regression It used to work, and now it doesn't triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@malfet
Copy link
Contributor

malfet commented Apr 29, 2025 •
edited by pytorch-bot bot
Loading

🐛 Describe the bug

May be it's just me, but newly added lint jobs keeps intermittently failing on PRs/trunk, for example
https://github.com/pytorch/pytorch/actions/runs/14737078933/job/41365789268

Versions

CI

cc @seemethere @pytorch/pytorch-dev-infra @clee2000
@malfet malfet added module: ci Related to continuous integration module: flaky-tests Problem is a flaky test in CI module: regression It used to work, and now it doesn't triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 29, 2025
@malfet
Copy link
Contributor Author

malfet commented Apr 29, 2025

Another example: https://github.com/pytorch/pytorch/actions/runs/14737222074/job/41367536629?pr=152395#step:15:5573

@huydhn
Copy link
Contributor

huydhn commented Apr 29, 2025

cc @shoumikhin

@huydhn
Copy link
Contributor

huydhn commented Apr 29, 2025

I'm going to move this to unstable till we can confirm that the job is stable enough after all the recent fixes

@huydhn huydhn self-assigned this Apr 29, 2025
@huydhn huydhn moved this to In Progress in PyTorch OSS Dev Infra Apr 29, 2025
@clee2000
Copy link
Contributor

If this still happens after the fixes, one thing to investigate might be if we're getting rate limited by stack overflow

@shoumikhin
Copy link
Contributor

I'm going to do something like this:
https://github.com/pytorch/executorch/pull/10558/files

@shoumikhin shoumikhin mentioned this issue Apr 29, 2025
Closed
@shoumikhin
Copy link
Contributor

Ok, ExecuTorch one works, hope #152464 works too now.
@huydhn @malfet ptal

pytorchmergebot pushed a commit that referenced this issue Apr 29, 2025
@shoumikhin @pytorchmergebot
Run link checks on modified files on push too (#152464)
accffef 
#152439
Pull Request resolved: #152464
Approved by: https://github.com/huydhn
@huydhn
Copy link
Contributor

huydhn commented May 1, 2025

I think the job is in a better shape now after #152377. We want to keep this issue open for a few more days to ensure that most PRs are rebased pass #152377. Then, thie can be closed

@atalman
Copy link
Contributor

atalman commented May 2, 2025

@huydhn and @shoumikhin should we disable this ? Here are the failures: https://github.com/pytorch/pytorch/actions/runs/14799982778/job/41556256522

parse error: Invalid numeric literal at line 1, column 6
400 https://download.pytorch.org/whl/%CHANNEL%/xpu .ci/pytorch/windows/internal/smoke_test.bat

This is existing code and URL is constructed.

We should be able to skip the check using some tags in the code or something like this.

@huydhn
Copy link
Contributor

huydhn commented May 2, 2025

As they are legit FP when the script doesn't know the value of %CHANNEL%, could you see if adding # @lint-ignore works for you, for example, https://github.com/pytorch/pytorch/pull/152237/files#diff-77e98c60778c936cb1bfb6e711ae97f2a201c3c2acdf4322cd858f13157222e2L131

@shoumikhin
Copy link
Contributor

@atalman please try appending & REM @lint-ignore to the line containing the URL

@malfet malfet mentioned this issue May 8, 2025
Closed
pytorchmergebot pushed a commit that referenced this issue May 8, 2025
@malfet @pytorchmergebot
Skip lintchecks for now (#153156)
30a3c5d 
As devs has been complaining it's failing. Completely remove them from lint.yml as #153157 moved it to nightly

See #152439  as well as #152884 and #152489 for more details

Was introduced in #152377
Pull Request resolved: #153156
Approved by: https://github.com/albanD, https://github.com/ZainRizvi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huydhn huydhn

Labels
module: ci Related to continuous integration module: flaky-tests Problem is a flaky test in CI module: regression It used to work, and now it doesn't triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
PyTorch OSS Dev Infra
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shoumikhin @huydhn @malfet @atalman @clee2000