[executorch] Let custom ops registration code only import ATen headers#107064
Closed
larryliu0820 wants to merge 1 commit into
Closed
[executorch] Let custom ops registration code only import ATen headers#107064larryliu0820 wants to merge 1 commit into
larryliu0820 wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107064
Note: Links to docs will display an error until the docs builds have been completed. ✅ 2 Unrelated FailuresAs of commit dee2dea: UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48282828 |
kirklandsign
approved these changes
Aug 11, 2023
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48282828 |
89fca5d to
0c41d2c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48282828 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48282828 |
0c41d2c to
5a8dd23
Compare
…rs (pytorch#107064) Summary: Pull Request resolved: pytorch#107064 Basically we generate `CustomOpsNativeFunctions.h` for registering custom ops into PyTorch JIT runtime. This header needs to hookup with the C++ kernel implementation of all the custom ops. For this reason it should include ATen headers instead of Executorch headers. This PR changes it. Test Plan: Rely on existing CI jobs Reviewed By: kirklandsign Differential Revision: D48282828 fbshipit-source-id: 72302976f0375bc9560b83d1632703e07c614e3e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48282828 |
5a8dd23 to
dee2dea
Compare
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Aug 13, 2023
Summary: X-link: pytorch/pytorch#107064 Basically we generate `CustomOpsNativeFunctions.h` for registering custom ops into PyTorch JIT runtime. This header needs to hookup with the C++ kernel implementation of all the custom ops. For this reason it should include ATen headers instead of Executorch headers. This PR changes it. Reviewed By: kirklandsign Differential Revision: D48282828 fbshipit-source-id: cf4ed96a7fb899b85a71d7efbc3fcd6c5a38632d
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Basically we generate
CustomOpsNativeFunctions.hfor registering custom ops into PyTorch JIT runtime. This header needs to hookup with the C++ kernel implementation of all the custom ops. For this reason it should include ATen headers instead of Executorch headers. This PR changes it.Test Plan: Rely on existing CI jobs
Differential Revision: D48282828