Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MPS] Add support for Mish to MPS backend #109786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[MPS] Add support for Mish to MPS backend #109786

wants to merge 3 commits into from

Conversation

igm503
Copy link
Contributor

@igm503 igm503 commented Sep 21, 2023

Fixes #ISSUE_NUMBER

Adds the mish activation function to the mps backend.

@igm503 igm503 requested a review from kulinseth as a code owner September 21, 2023 13:47
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109786

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 180d4f3 with merge base 0317626 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Sep 21, 2023
kulinseth
kulinseth approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@igm503
Copy link
Contributor Author

igm503 commented Sep 21, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@khari998
Copy link

@igm503 Thank you so much

@chenhuiapp
Copy link

is aten::mish.out supported on MPS now?

@igm503
Copy link
Contributor Author

igm503 commented Dec 8, 2023

@chenhuiapp I believe it's currently only available in the nightlies. It should be available in the normal distribution the next time there's an update.

@chenhuiapp
Copy link

@igm503 thank you! I will try nightly.

@aleksandrsuslov
Copy link

Any updates? Is mish supported now in pytorch 2.3?

@khari998
Copy link

Any updates? Is mish supported now in pytorch 2.3?

It is for me. Have you tried it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General MPS op coverage tracking issue
7 participants
@igm503 @pytorchmergebot @khari998 @chenhuiapp @aleksandrsuslov @kulinseth @pytorchbot